[Kde-games-devel] Review Request: avoid a crash because of a negative area

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107739/#review23537
-----------------------------------------------------------


Waht do you mean R*R and C*C ?

Also this is quite interesting because box2d is used in lots of projects and looking at their upstream code (don't ask me why we have it embedded) it seems the function is still unchanged

- Albert Astals Cid


On Dec. 15, 2012, 6:09 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107739/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2012, 6:09 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Avoid a crash starting kolf.
> The crash comes when the calculated area is <0, something impossible in R*R (only in C*C).
> The patch makes the area always >=0.
> 
> The patch is similar to what I proposed then, but I forgot how to use reviewboard for svn.
> 
> 
> This addresses bug 258998.
>     http://bugs.kde.org/show_bug.cgi?id=258998
> 
> 
> Diffs
> -----
> 
>   external/Box2D/Collision/Shapes/b2PolygonShape.cpp c96583b 
> 
> Diff: http://git.reviewboard.kde.org/r/107739/diff/
> 
> 
> Testing
> -------
> 
> before, the crash (yes, I still suffer it).
> after, kolf runs.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121216/ee6fbca3/attachment.html>