[Kde-games-devel] Review Request: Fix & improve kmines mouse actions

[Albert Astals Cid]

> On Dec. 16, 2012, 3:16 p.m., Albert Astals Cid wrote:
> > When pressing the middle mouse button the behaviour has changed, previously the square where the mouse was wasn't "down", while now it is. Is this on purspose?
> 
> Andrew Wallace wrote:
>     Yes this is intentional. Having the center square unpressed causes additional corner cases when the mouse is dragged partially of the playing field. I could have kept the behavior the same with more code but thought it not worthwhile.
> 
> Albert Astals Cid wrote:
>     To be honest i do not think this kind of behavioural change makes sense if we are speaking of doing a bugfix. A bugfix should fix bugs, not change how things work in the general case for the user.
> 
> Andrew Wallace wrote:
>     Then the users can keep their bugs. There is not enough time before the tag freeze for me to make a large change like that, and frankly with the amount of time between when I submitted the patch and when this issue was brought up I've lost interest in working on cosmetics.
>     
>     Not trying to be rude or point fingers, just stating how things stand.

I'm sorry you lost interest in fixing the bug, we are low on man power and thus it takes some time for people to review code. We do monthly releases with fixes, so not having time is never an excuse for not finishing a patch or commiting it in with behaviour regressions, there's always a new release at the corner of the street.

We are sincerely interested in getting the bugfixes in, but UI is as important as bugfixes, so please reconsider your position.

If you are not interested in pursuing quality code please discard this review request so it does not clutter our queue of things to review


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107067/#review23539
-----------------------------------------------------------


On Dec. 15, 2012, 1:53 a.m., Andrew Wallace wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107067/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2012, 1:53 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This does two things:
> 
> 1) Be safer about cleaning up visually 'pressing' squares.
> 2) Have a left click on a revealed square act the same as a middle click.
> 
> The patch changes how the mouse actions are handled. Storing what action is started with the mouse down event. Makes the logic more generic.
> 
> (Please be kind, it's my first patch.)
> 
> 
> This addresses bugs 221725 and 284952.
>     http://bugs.kde.org/show_bug.cgi?id=221725
>     http://bugs.kde.org/show_bug.cgi?id=284952
> 
> 
> Diffs
> -----
> 
>   minefielditem.h a6319d3 
>   minefielditem.cpp 3e77cc1 
> 
> Diff: http://git.reviewboard.kde.org/r/107067/diff/
> 
> 
> Testing
> -------
> 
> Testing was by hand, here are the cases I made sure to try and looked for press artifacts:
> 
> 1) Steps in bug 221725.
> 
> 2) Middle drag then right clicked on tool bar.
> 
> 3) Right down. Drag. Left down. Drag. Both release. (And vice versa.)
> 
> 4) Middle down. Drag off play area. Release. Left click anything.
> 
> 
> Thanks,
> 
> Andrew Wallace
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121217/61dde6f8/attachment-0001.html>