[Kde-games-devel] Review Request: Attempt to fix null pointer issue in Game::map.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/7013/#review10900
-----------------------------------------------------------



/branches/KDE/4.8/kdegames/konquest/game.cpp
<http://svn.reviewboard.kde.org/r/7013/#comment13532>

    Can you actually reproduce this? Not sure creating a random map when this happens is a good idea.


- Albert Astals Cid


On July 30, 2012, 7:23 p.m., Michael Reeves wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/7013/
> -----------------------------------------------------------
> 
> (Updated July 30, 2012, 7:23 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Attempt to fix crash due to null Map pointer. Prevents calling GameView::startNewGame or GameView::gameOver before GameView is fully ready the cause of my variant. Null pointer check is done in Game::map as a workaround for the reported variant which seems to have a different root cause.
> 
> 
> This addresses bug 296290.
>     https://bugs.kde.org/show_bug.cgi?id=296290
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.8/kdegames/konquest/game.h 1308596 
>   /branches/KDE/4.8/kdegames/konquest/game.cpp 1308596 
>   /branches/KDE/4.8/kdegames/konquest/gameview.h 1308596 
>   /branches/KDE/4.8/kdegames/konquest/gameview.cc 1308596 
> 
> Diff: http://svn.reviewboard.kde.org/r/7013/diff/
> 
> 
> Testing
> -------
> 
> It fixes a related variant I was able to produce on my machine. I am unable to reproduce the bug as reported. Attempted to work around issue based on the stack traces alone.
> 
> 
> Thanks,
> 
> Michael Reeves
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120805/82ef06d1/attachment.html>