[Kde-games-devel] Review Request: Attempt to fix null pointer issue in Game::map.

[Michael Reeves]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/7013/
-----------------------------------------------------------

(Updated Aug. 6, 2012, 7:03 p.m.)


Review request for KDE Games.


Changes
-------

Let's just leave at fixing what I found happening. The stack trace in the bug is different so I don't know if this will fix that issue.


Description
-------

Attempt to fix crash due to null Map pointer. Prevents calling GameView::startNewGame or GameView::gameOver before GameView is fully ready the cause of my variant. Null pointer check is done in Game::map as a workaround for the reported variant which seems to have a different root cause.


This addresses bug 296290.
    https://bugs.kde.org/show_bug.cgi?id=296290


Diffs (updated)
-----

  /branches/KDE/4.8/kdegames/konquest/gameview.h 1308596 
  /branches/KDE/4.8/kdegames/konquest/gameview.cc 1308596 

Diff: http://svn.reviewboard.kde.org/r/7013/diff/


Testing
-------

It fixes a related variant I was able to produce on my machine. I am unable to reproduce the bug as reported. Attempted to work around issue based on the stack traces alone.


Thanks,

Michael Reeves

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120806/87bfc43d/attachment.html>