[Kde-games-devel] Review Request: Porting KBounce to KgSound
Roney Gomes
roney477 at gmail.com
Fri Apr 27 23:06:49 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6930/
-----------------------------------------------------------
(Updated April 27, 2012, 11:06 p.m.)
Review request for KDE Games.
Changes
-------
Compilation errors and warnings were removed.
Description
-------
The changed files were:
- CMakeLists.txt
- board.h
- board.cpp
- gamewidget.h
- gamewidget.cpp
- mainwindow.cpp
- wall.h
- wall.cpp
The class KBounceSound is no more necessary.
Diffs (updated)
-----
/trunk/KDE/kdegames/kbounce/CMakeLists.txt 1292134
/trunk/KDE/kdegames/kbounce/board.h 1292134
/trunk/KDE/kdegames/kbounce/board.cpp 1292134
/trunk/KDE/kdegames/kbounce/gamewidget.h 1292134
/trunk/KDE/kdegames/kbounce/gamewidget.cpp 1292134
/trunk/KDE/kdegames/kbounce/mainwindow.cpp 1292134
/trunk/KDE/kdegames/kbounce/wall.h 1292134
/trunk/KDE/kdegames/kbounce/wall.cpp 1292134
Diff: http://svn.reviewboard.kde.org/r/6930/diff/
Testing
-------
I've played the game in the following conditions:
- sounds enabled and running
- sounds disable and running
- paused, sounds disabled, and then running
- paused, sounds enabled, and then running
I could not advance to the next levels because there is a commented block of code in the file that handles the main window. Since I don't know whether there's someone working on it, thought that would be better leave it the way it is.
Thanks,
Roney Gomes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120427/c4022263/attachment-0001.html>
More information about the kde-games-devel
mailing list