[Kde-games-devel] Review Request: Porting KBounce to KgSound

[Roney Gomes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6930/
-----------------------------------------------------------

(Updated April 15, 2012, 4:27 p.m.)


Review request for KDE Games.


Changes
-------

Compiler warnings removed.

There was a difference between the order in which the objects were declared and the order in which they were initialized. 


Description
-------

The changed files were:
- CMakeLists.txt
- board.h
- board.cpp
- gamewidget.h
- gamewidget.cpp
- mainwindow.cpp
- wall.h
- wall.cpp

The class KBounceSound is no more necessary.


Diffs (updated)
-----

  /trunk/KDE/kdegames/kbounce/CMakeLists.txt 1289692 
  /trunk/KDE/kdegames/kbounce/board.h 1289692 
  /trunk/KDE/kdegames/kbounce/board.cpp 1289692 
  /trunk/KDE/kdegames/kbounce/gamewidget.h 1289692 
  /trunk/KDE/kdegames/kbounce/gamewidget.cpp 1289692 
  /trunk/KDE/kdegames/kbounce/mainwindow.cpp 1289692 
  /trunk/KDE/kdegames/kbounce/wall.h 1289692 
  /trunk/KDE/kdegames/kbounce/wall.cpp 1289692 

Diff: http://svn.reviewboard.kde.org/r/6930/diff/


Testing
-------

I've played the game in the following conditions:
- sounds enabled and running
- sounds disable and running
- paused, sounds disabled, and then running
- paused, sounds enabled, and then running

I could not advance to the next levels because there is a commented block of code in the file that handles the main window. Since I don't know whether there's someone working on it, thought that would be better leave it the way it is. 


Thanks,

Roney Gomes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120415/70760b05/attachment.html>