<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6930/">http://svn.reviewboard.kde.org/r/6930/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Roney Gomes.</div>
<p style="color: grey;"><i>Updated April 15, 2012, 4:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiler warnings removed.
There was a difference between the order in which the objects were declared and the order in which they were initialized. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The changed files were:
- CMakeLists.txt
- board.h
- board.cpp
- gamewidget.h
- gamewidget.cpp
- mainwindow.cpp
- wall.h
- wall.cpp
The class KBounceSound is no more necessary.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've played the game in the following conditions:
- sounds enabled and running
- sounds disable and running
- paused, sounds disabled, and then running
- paused, sounds enabled, and then running
I could not advance to the next levels because there is a commented block of code in the file that handles the main window. Since I don't know whether there's someone working on it, thought that would be better leave it the way it is. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/kbounce/CMakeLists.txt <span style="color: grey">(1289692)</span></li>
<li>/trunk/KDE/kdegames/kbounce/board.h <span style="color: grey">(1289692)</span></li>
<li>/trunk/KDE/kdegames/kbounce/board.cpp <span style="color: grey">(1289692)</span></li>
<li>/trunk/KDE/kdegames/kbounce/gamewidget.h <span style="color: grey">(1289692)</span></li>
<li>/trunk/KDE/kdegames/kbounce/gamewidget.cpp <span style="color: grey">(1289692)</span></li>
<li>/trunk/KDE/kdegames/kbounce/mainwindow.cpp <span style="color: grey">(1289692)</span></li>
<li>/trunk/KDE/kdegames/kbounce/wall.h <span style="color: grey">(1289692)</span></li>
<li>/trunk/KDE/kdegames/kbounce/wall.cpp <span style="color: grey">(1289692)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6930/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>