[Kde-games-devel] Review Request: Porting KBounce to KgSound

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6930/#review10765
-----------------------------------------------------------


I get a linker error:

CMakeFiles/kbounce.dir/gamewidget.o: In function `KBounceGameWidget::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)':
gamewidget.moc:90: undefined reference to `KBounceGameWidget::setSounds(bool)'
gamewidget.moc:91: undefined reference to `KBounceGameWidget::setSoundPath(QString const&)'

I guess you intended to remove those functions? Then there are also some compiler errors:


/trunk/KDE/kdegames/kbounce/gamewidget.cpp
<http://svn.reviewboard.kde.org/r/6930/#comment13304>

    gamewidget.h: In constructor ‘KBounceGameWidget::KBounceGameWidget(QWidget*)’:
    gamewidget.h:98:7: warning: ‘KBounceGameWidget::m_vertical’ will be initialized after [-Wreorder]
    gamewidget.h:83:10: warning:   ‘KgSound KBounceGameWidget::m_soundTimeout’ [-Wreorder]
    gamewidget.cpp:36:1: warning:   when initialized here [-Wreorder]
    



/trunk/KDE/kdegames/kbounce/wall.cpp
<http://svn.reviewboard.kde.org/r/6930/#comment13303>

    wall.h: In constructor ‘KBounceWall::KBounceWall(KBounceWall::Direction, KBounceRenderer*, KBounceBoard*)’:
    wall.h:125:8: warning: ‘KBounceWall::m_tileSize’ will be initialized after [-Wreorder]
    wall.h:120:10: warning:   ‘KgSound KBounceWall::m_soundWallstart’ [-Wreorder]
    wall.cpp:31:1: warning:   when initialized here [-Wreorder]
    


- Stefan Majewsky


On March 28, 2012, 10:21 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6930/
> -----------------------------------------------------------
> 
> (Updated March 28, 2012, 10:21 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> The changed files were:
> - CMakeLists.txt
> - board.h
> - board.cpp
> - gamewidget.h
> - gamewidget.cpp
> - mainwindow.cpp
> - wall.h
> - wall.cpp
> 
> The class KBounceSound is no more necessary.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kbounce/CMakeLists.txt 1287517 
>   /trunk/KDE/kdegames/kbounce/board.h 1287517 
>   /trunk/KDE/kdegames/kbounce/board.cpp 1287517 
>   /trunk/KDE/kdegames/kbounce/gamewidget.h 1287517 
>   /trunk/KDE/kdegames/kbounce/gamewidget.cpp 1287517 
>   /trunk/KDE/kdegames/kbounce/mainwindow.cpp 1287517 
>   /trunk/KDE/kdegames/kbounce/wall.h 1287517 
>   /trunk/KDE/kdegames/kbounce/wall.cpp 1287517 
> 
> Diff: http://svn.reviewboard.kde.org/r/6930/diff/
> 
> 
> Testing
> -------
> 
> I've played the game in the following conditions:
> - sounds enabled and running
> - sounds disable and running
> - paused, sounds disabled, and then running
> - paused, sounds enabled, and then running
> 
> I could not advance to the next levels because there is a commented block of code in the file that handles the main window. Since I don't know whether there's someone working on it, thought that would be better leave it the way it is. 
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120415/560b1de9/attachment.html>