<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6930/">http://svn.reviewboard.kde.org/r/6930/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I get a linker error:
CMakeFiles/kbounce.dir/gamewidget.o: In function `KBounceGameWidget::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)':
gamewidget.moc:90: undefined reference to `KBounceGameWidget::setSounds(bool)'
gamewidget.moc:91: undefined reference to `KBounceGameWidget::setSoundPath(QString const&)'
I guess you intended to remove those functions? Then there are also some compiler errors:</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6930/diff/1/?file=47763#file47763line44" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdegames/kbounce/gamewidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">,</span> <span class="n">m_soundTimeout</span><span class="p">(</span> <span class="n">KStandardDirs</span><span class="o">::</span><span class="n">locate</span><span class="p">(</span> <span class="s">"appdata"</span><span class="p">,</span> <span class="s">"sounds/timeout.wav"</span> <span class="p">)</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">gamewidget.h: In constructor ‘KBounceGameWidget::KBounceGameWidget(QWidget*)’:
gamewidget.h:98:7: warning: ‘KBounceGameWidget::m_vertical’ will be initialized after [-Wreorder]
gamewidget.h:83:10: warning: ‘KgSound KBounceGameWidget::m_soundTimeout’ [-Wreorder]
gamewidget.cpp:36:1: warning: when initialized here [-Wreorder]
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6930/diff/1/?file=47766#file47766line38" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdegames/kbounce/wall.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">37</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">,</span> <span class="n">m_soundWallstart</span><span class="p">(</span> <span class="n">KStandardDirs</span><span class="o">::</span><span class="n">locate</span><span class="p">(</span> <span class="s">"appdata"</span><span class="p">,</span> <span class="s">"sounds/wallstart.wav"</span> <span class="p">)</span> <span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">,</span> <span class="n">m_soundReflect</span><span class="p">(</span> <span class="n">KStandardDirs</span><span class="o">::</span><span class="n">locate</span><span class="p">(</span> <span class="s">"appdata"</span><span class="p">,</span> <span class="s">"sounds/reflect.wav"</span> <span class="p">)</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">wall.h: In constructor ‘KBounceWall::KBounceWall(KBounceWall::Direction, KBounceRenderer*, KBounceBoard*)’:
wall.h:125:8: warning: ‘KBounceWall::m_tileSize’ will be initialized after [-Wreorder]
wall.h:120:10: warning: ‘KgSound KBounceWall::m_soundWallstart’ [-Wreorder]
wall.cpp:31:1: warning: when initialized here [-Wreorder]
</pre>
</div>
<br />
<p>- Stefan</p>
<br />
<p>On March 28th, 2012, 10:21 p.m., Roney Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Roney Gomes.</div>
<p style="color: grey;"><i>Updated March 28, 2012, 10:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The changed files were:
- CMakeLists.txt
- board.h
- board.cpp
- gamewidget.h
- gamewidget.cpp
- mainwindow.cpp
- wall.h
- wall.cpp
The class KBounceSound is no more necessary.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've played the game in the following conditions:
- sounds enabled and running
- sounds disable and running
- paused, sounds disabled, and then running
- paused, sounds enabled, and then running
I could not advance to the next levels because there is a commented block of code in the file that handles the main window. Since I don't know whether there's someone working on it, thought that would be better leave it the way it is. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/kbounce/CMakeLists.txt <span style="color: grey">(1287517)</span></li>
<li>/trunk/KDE/kdegames/kbounce/board.h <span style="color: grey">(1287517)</span></li>
<li>/trunk/KDE/kdegames/kbounce/board.cpp <span style="color: grey">(1287517)</span></li>
<li>/trunk/KDE/kdegames/kbounce/gamewidget.h <span style="color: grey">(1287517)</span></li>
<li>/trunk/KDE/kdegames/kbounce/gamewidget.cpp <span style="color: grey">(1287517)</span></li>
<li>/trunk/KDE/kdegames/kbounce/mainwindow.cpp <span style="color: grey">(1287517)</span></li>
<li>/trunk/KDE/kdegames/kbounce/wall.h <span style="color: grey">(1287517)</span></li>
<li>/trunk/KDE/kdegames/kbounce/wall.cpp <span style="color: grey">(1287517)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6930/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>