[Kde-games-devel] Review Request: Porting Bomber from KGameCanvas to QGraphicsView

[Stefan Majewsky]

> On March 22, 2012, 8:42 p.m., Mehmet Emre wrote:
> > Should I close the patch as submitted now? There's been no reviews for request for one week and I think that it's fine.
> 
> Parker Coates wrote:
>     Do you have developer access to commit it or are you hoping someone will commit it for you? If you don't have developer access, but are interested, see here: http://techbase.kde.org/Contribute/Get_a_Contributor_Account
> 
> Mehmet Emre wrote:
>     I don't have developer access, so may someone else commit it for me? I'll apply for a contributor account for further contributions.

Committed to trunk. Please close.


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6908/#review10733
-----------------------------------------------------------


On March 13, 2012, 9:52 p.m., Mehmet Emre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6908/
> -----------------------------------------------------------
> 
> (Updated March 13, 2012, 9:52 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> I've ported bomber to QGraphicsView as requested here: http://techbase.kde.org/Projects/Games/Porting. I've made some modifications on the classes below:
> - Explodable
> - BomberBoard
> - BomberGameWidget
> - Building
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/bomber/src/board.h 1284898 
>   trunk/KDE/kdegames/bomber/src/board.cpp 1284898 
>   trunk/KDE/kdegames/bomber/src/bomber.cpp 1284898 
>   trunk/KDE/kdegames/bomber/src/bomberwidget.h 1284898 
>   trunk/KDE/kdegames/bomber/src/bomberwidget.cpp 1284898 
>   trunk/KDE/kdegames/bomber/src/building.h 1284898 
>   trunk/KDE/kdegames/bomber/src/building.cpp 1284898 
>   trunk/KDE/kdegames/bomber/src/explodable.h 1284898 
>   trunk/KDE/kdegames/bomber/src/explodable.cpp 1284898 
>   trunk/KDE/kdegames/bomber/src/main.cpp 1284898 
> 
> Diff: http://svn.reviewboard.kde.org/r/6908/diff/
> 
> 
> Testing
> -------
> 
> I've done these tests and solved the problems that I've bumped into:
> - Played bomber's first two levels.
> - Paused the game
> - Changed settings during the game and while game is paused.
> 
> 
> Thanks,
> 
> Mehmet Emre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120415/38f19c40/attachment-0001.html>