[Kde-games-devel] Review Request: Knetwalk rotation reduction

Ben Longbons brlongbons at gmail.com
Sun Apr 8 18:50:17 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6935/
-----------------------------------------------------------

Review request for KDE Games.


Description
-------

This knetwalk patch keeps track of the last cell edited and how it
changed, so that suboptimal click sequences are not penalized.

* Left click + right click is equivalent to no click (useful if your
middle mouse button by simultaneously clicking the other two and you
hit them at different times)
* 3 clicks is equivalent to a click in the opposite direction.
* Special handling is applied for straight pipes -  any 2 clicks is
equivalent to no click

Note that this is *not* general undo support, just mistake prevention
and convenience for the single most recent cell.


Diffs
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/fielditem.h 1287365 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/fielditem.cpp 1287365 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/mainwindow.h 1287365 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/mainwindow.cpp 1287365 

Diff: http://svn.reviewboard.kde.org/r/6935/diff/


Testing
-------

Tested against trunk, and also against 4.8.2 after changing the Kg::difficulty back to KGameDifficulty

(The first round of testing made me implement the special behavior for straight pipes)


Thanks,

Ben Longbons

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120408/be25b869/attachment-0001.html>


More information about the kde-games-devel mailing list