[Kde-games-devel] Review Request: Knetwalk rotation reduction

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6935/#review10767
-----------------------------------------------------------


Looks good, but I didn't compile.


svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/fielditem.h
<http://svn.reviewboard.kde.org/r/6935/#comment13305>

    I'd rather use m_activeCell for m_lastCell, that is: allow the undo only until the mouse leaves the currently highlighted cell. Opinions?


- Stefan Majewsky


On April 8, 2012, 6:50 p.m., Ben Longbons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6935/
> -----------------------------------------------------------
> 
> (Updated April 8, 2012, 6:50 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This knetwalk patch keeps track of the last cell edited and how it
> changed, so that suboptimal click sequences are not penalized.
> 
> * Left click + right click is equivalent to no click (useful if your
> middle mouse button by simultaneously clicking the other two and you
> hit them at different times)
> * 3 clicks is equivalent to a click in the opposite direction.
> * Special handling is applied for straight pipes -  any 2 clicks is
> equivalent to no click
> 
> Note that this is *not* general undo support, just mistake prevention
> and convenience for the single most recent cell.
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/fielditem.h 1287365 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/fielditem.cpp 1287365 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/mainwindow.h 1287365 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/mainwindow.cpp 1287365 
> 
> Diff: http://svn.reviewboard.kde.org/r/6935/diff/
> 
> 
> Testing
> -------
> 
> Tested against trunk, and also against 4.8.2 after changing the Kg::difficulty back to KGameDifficulty
> 
> (The first round of testing made me implement the special behavior for straight pipes)
> 
> 
> Thanks,
> 
> Ben Longbons
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120415/25221edd/attachment-0001.html>