[Kde-games-devel] Review Request: Increase the Row Height of Kiriki

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6931/#review10760
-----------------------------------------------------------



/trunk/KDE/kdegames/kiriki/src/scores.cpp
<http://svn.reviewboard.kde.org/r/6931/#comment13298>

    What's this if?



/trunk/KDE/kdegames/kiriki/src/scores.cpp
<http://svn.reviewboard.kde.org/r/6931/#comment13299>

    row 1 for top?
    column 0 for right?
    I'd say those values are wrong


- Albert Astals Cid


On April 6, 2012, 5:09 p.m., Arjun Basu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6931/
> -----------------------------------------------------------
> 
> (Updated April 6, 2012, 5:09 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This is in response to the feature request https://bugs.kde.org/show_bug.cgi?id=225582. Now, there is a provision of increasing the font size and as a result the row height increases too. The value of the font size in the preferences can take values from 0 to 10. O being the default font size.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/configPage.ui 1282954 
>   /trunk/KDE/kdegames/kiriki/src/configwidget.h 1282954 
>   /trunk/KDE/kdegames/kiriki/src/configwidget.cpp 1282954 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1282954 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.kcfg 1282954 
>   /trunk/KDE/kdegames/kiriki/src/row.h 1282954 
>   /trunk/KDE/kdegames/kiriki/src/scores.h 1282954 
>   /trunk/KDE/kdegames/kiriki/src/scores.cpp 1282954 
> 
> Diff: http://svn.reviewboard.kde.org/r/6931/diff/
> 
> 
> Testing
> -------
> 
> I have tested it and it works fine
> 
> 
> Screenshots
> -----------
> 
> The New Preferences Dialog
>   http://svn.reviewboard.kde.org/r/6931/s/629/
> The Game Canvas after increasing font size
>   http://svn.reviewboard.kde.org/r/6931/s/630/
> 
> 
> Thanks,
> 
> Arjun Basu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120408/63d87cf5/attachment-0001.html>