[Kde-games-devel] Review Request: Increase the Row Height of Kiriki

[Arjun Basu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6931/
-----------------------------------------------------------

(Updated April 8, 2012, 12:38 p.m.)


Review request for KDE Games.


Changes
-------

The if condition was not really required so I removed it. The parameters in dataChanged() have been corrected. Now it is 0,0 for the top left and m_rows.count()-1 and m_players.count()-1 for the bottom right


Description
-------

This is in response to the feature request https://bugs.kde.org/show_bug.cgi?id=225582. Now, there is a provision of increasing the font size and as a result the row height increases too. The value of the font size in the preferences can take values from 0 to 10. O being the default font size.


Diffs (updated)
-----

  /trunk/KDE/kdegames/kiriki/src/configPage.ui 1282954 
  /trunk/KDE/kdegames/kiriki/src/configwidget.h 1282954 
  /trunk/KDE/kdegames/kiriki/src/configwidget.cpp 1282954 
  /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1282954 
  /trunk/KDE/kdegames/kiriki/src/kiriki.kcfg 1282954 
  /trunk/KDE/kdegames/kiriki/src/row.h 1282954 
  /trunk/KDE/kdegames/kiriki/src/scores.h 1282954 
  /trunk/KDE/kdegames/kiriki/src/scores.cpp 1282954 

Diff: http://svn.reviewboard.kde.org/r/6931/diff/


Testing
-------

I have tested it and it works fine


Screenshots
-----------

The New Preferences Dialog
  http://svn.reviewboard.kde.org/r/6931/s/629/
The Game Canvas after increasing font size
  http://svn.reviewboard.kde.org/r/6931/s/630/


Thanks,

Arjun Basu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120408/18df484c/attachment.html>