[Kde-games-devel] Review Request: kmahjongg: after shuffle no information about "no moves left"

[Frederik Schwarzer]

> On Dec. 13, 2011, 9:30 p.m., Frederik Schwarzer wrote:
> > This one seems fine to me.
> > Might it also be a candidate for a bugfix for 4.8?
> 
> Christian Krippendorf wrote:
>     For me, ... it should :) After fixing the little whitespace things. Tomorrow i will have a look if i can commit two bug resolves. Don't know about still in freeze for beta now.
> 
> Ian Wadham wrote:
>     I committed a fix to KSudoku on Monday and there were no objections. So go for it!

December 19th is the freeze for RC1, so commit it before that date, please.

In the commit message, use the BUG keyword and the REVIEW keyword.
BUG should not have an effect for you yet because you do not have the rights to close reports. I will habe a look after your commit and close the report then.
REVIEW does not have an effect on svn.reviewboard.kde.org but it helps with relating commits to reviews. You will have to close this report after your commit. Preferably with a link to the commit.

Here is an example commit message.
    Implement standing orders

    Here can come a more detailled description of what the commit does.

    BUG: 87882
    REVIEW: 6805

Regards


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6837/#review10552
-----------------------------------------------------------


On Dec. 14, 2011, 11:24 a.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6837/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2011, 11:24 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=287411
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.h 1268717 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.cpp 1268717 
> 
> Diff: http://svn.reviewboard.kde.org/r/6837/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20111214/268f2e3c/attachment.html>