<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6837/">http://svn.reviewboard.kde.org/r/6837/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 13th, 2011, 9:30 p.m., <b>Frederik Schwarzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This one seems fine to me.
Might it also be a candidate for a bugfix for 4.8?</pre>
</blockquote>
<p>On December 13th, 2011, 9:36 p.m., <b>Christian Krippendorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For me, ... it should :) After fixing the little whitespace things. Tomorrow i will have a look if i can commit two bug resolves. Don't know about still in freeze for beta now.</pre>
</blockquote>
<p>On December 14th, 2011, 12:39 a.m., <b>Ian Wadham</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I committed a fix to KSudoku on Monday and there were no objections. So go for it!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">December 19th is the freeze for RC1, so commit it before that date, please.
In the commit message, use the BUG keyword and the REVIEW keyword.
BUG should not have an effect for you yet because you do not have the rights to close reports. I will habe a look after your commit and close the report then.
REVIEW does not have an effect on svn.reviewboard.kde.org but it helps with relating commits to reviews. You will have to close this report after your commit. Preferably with a link to the commit.
Here is an example commit message.
Implement standing orders
Here can come a more detailled description of what the commit does.
BUG: 87882
REVIEW: 6805
Regards</pre>
<br />
<p>- Frederik</p>
<br />
<p>On December 14th, 2011, 11:24 a.m., Christian Krippendorf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Christian Krippendorf.</div>
<p style="color: grey;"><i>Updated Dec. 14, 2011, 11:24 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug List Link: https://bugs.kde.org/show_bug.cgi?id=287411</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/kmahjongg/boardwidget.h <span style="color: grey">(1268717)</span></li>
<li>trunk/KDE/kdegames/kmahjongg/boardwidget.cpp <span style="color: grey">(1268717)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6837/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>