[Kde-games-devel] Review Request: kmahjongg: Undo after won is allowed

Frederik Schwarzer schwarzer at kde.org
Wed Dec 14 13:36:27 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6841/#review10573
-----------------------------------------------------------


This is a bugfix but not for a serious bug. Since there is a new string, I would not commit it for 4.8.


trunk/KDE/kdegames/kmahjongg/boardwidget.cpp
<http://svn.reviewboard.kde.org/r/6841/#comment12574>

    Hmm, I am not very happy with the message. What about: "You have finished this board, there is nothing to be undone"?
    
    Maybe a native speaker could give advice here.


- Frederik Schwarzer


On Nov. 25, 2011, 7:19 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6841/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2011, 7:19 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=215352
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.cpp 1265765 
>   trunk/KDE/kdegames/kmahjongg/kmahjongg.cpp 1265765 
> 
> Diff: http://svn.reviewboard.kde.org/r/6841/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20111214/904dd3ae/attachment-0001.html>


More information about the kde-games-devel mailing list