[Kde-games-devel] Review Request: kmahjongg: select the wrong Stone if i click on the shadow of another stone

[Christian Krippendorf]

> On Dec. 2, 2011, 7:42 a.m., Frederik Schwarzer wrote:
> > trunk/KDE/kdegames/kmahjongg/boardwidget.cpp, line 905
> > <http://svn.reviewboard.kde.org/r/6839/diff/2/?file=47250#file47250line905>
> >
> >     Can you please think of other names for "el" and "pt"? Variable names can help while reading the code.

This naming was not done by me. Bad naming is a general problem of the whole code. I will change the code structure formatting and naming later in trunk and actually in my branch work/krippendorf-kmahjongg.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6839/#review10499
-----------------------------------------------------------


On Nov. 25, 2011, 7:15 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6839/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2011, 7:15 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=286927
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.h 1265765 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.cpp 1265765 
> 
> Diff: http://svn.reviewboard.kde.org/r/6839/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20111202/67c4b0f4/attachment.html>