[Kde-games-devel] Review Request: kmahjongg: select the wrong Stone if i click on the shadow of another stone

Frederik Schwarzer schwarzer at kde.org
Fri Dec 2 07:42:47 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6839/#review10499
-----------------------------------------------------------



trunk/KDE/kdegames/kmahjongg/boardwidget.cpp
<http://svn.reviewboard.kde.org/r/6839/#comment12436>

    Can you please think of other names for "el" and "pt"? Variable names can help while reading the code.


- Frederik Schwarzer


On Nov. 25, 2011, 7:15 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6839/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2011, 7:15 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=286927
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.h 1265765 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.cpp 1265765 
> 
> Diff: http://svn.reviewboard.kde.org/r/6839/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20111202/659b210d/attachment.html>


More information about the kde-games-devel mailing list