[Kde-games-devel] Review Request: kmahjongg: select the wrong Stone if i click on the shadow of another stone

[Christian Krippendorf]

> On Dec. 2, 2011, 6:30 a.m., Frederik Schwarzer wrote:
> > I will install this patch later and see if I understand it better then. For now, just this:
> 
> Frederik Schwarzer wrote:
>     From the user's point of view it is an improvement. However, I can still click around half of the shadow side-ways.
>     I am not sure I understand the code but do you use the width of the outside edge and cut that from the position? Or do I understand offsetX and offsetY wrong?
>     
>     Reading the code in general is quite an adventure. I wanted to look at your code but got stuck several times on the way down. ;)
>     Reformatting the whole thing might be a good idea at some point.
>     I even found German comments. :D

The last few days i made several reformattings and code changes in general for a better readable code. The whole code of kmajhongg is inconsistent and very bad to understand. But this will take a while. After that the whole code will be readable *hopefully* :)

Whatever, ... while reformatting the code i understand some parts better and i made a failure in this dif i thought. I will upload a new diff tomorrow (have a night shift today) and hopefully the code works than a bit better. Some explanations now:

The tiles.width() seem to be the whole tile including the shadow and the tiles.offsetX seem to be the hight of the stone. This is what i made wrong in this diff.

As i said, ... i will upload a new patch tomorrow.

Thx for review.


> On Dec. 2, 2011, 6:30 a.m., Frederik Schwarzer wrote:
> > trunk/KDE/kdegames/kmahjongg/boardwidget.cpp, line 884
> > <http://svn.reviewboard.kde.org/r/6839/diff/2/?file=47250#file47250line884>
> >
> >     Please use kDebug(), since qDebug cannot be turned off by "kdebugdialog" or when built in release mode.

Yearh i will change this tomorrow.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6839/#review10497
-----------------------------------------------------------


On Nov. 25, 2011, 7:15 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6839/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2011, 7:15 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=286927
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.h 1265765 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.cpp 1265765 
> 
> Diff: http://svn.reviewboard.kde.org/r/6839/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20111202/be9f69ce/attachment.html>