[Kde-games-devel] Re: Review Request: Port KLines to KGameRenderer

[Lindsay Mathieson]

> On April 17, 2011, 10:08 a.m., Frederik Schwarzer wrote:
> > I cannot apply this patch to trunk. klines/renderer.cpp fails. The .rej file has 280 lines. Any idea why this happens?

Are you using the updated diff? (Diff 4):
  https://svn.reviewboard.kde.org/r/5399/diff/4/


- Lindsay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5399/#review10063
-----------------------------------------------------------


On April 8, 2011, 5:17 a.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5399/
> -----------------------------------------------------------
> 
> (Updated April 8, 2011, 5:17 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Updates klines to use KGameRenderer and KGameRenderedItem in place of QSvgRenderer and QGraphicsPixmapItem
> Removes KPixmapCache usage
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/klines/animator.cpp 1227353 
>   /trunk/KDE/kdegames/klines/ballitem.h 1227353 
>   /trunk/KDE/kdegames/klines/ballitem.cpp 1227353 
>   /trunk/KDE/kdegames/klines/klines.cpp 1227353 
>   /trunk/KDE/kdegames/klines/previewitem.cpp 1227353 
>   /trunk/KDE/kdegames/klines/renderer.h 1227353 
>   /trunk/KDE/kdegames/klines/renderer.cpp 1177731 
>   /trunk/KDE/kdegames/klines/scene.cpp 1227353 
> 
> Diff: http://svn.reviewboard.kde.org/r/5399/diff
> 
> 
> Testing
> -------
> 
> Playing game
> Changing themes
> Resizing game
> Comparison with original
> 
> 
> Thanks,
> 
> Lindsay
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20110417/cec5aee9/attachment.htm