<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5399/">http://svn.reviewboard.kde.org/r/5399/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 17th, 2011, 10:08 a.m., <b>Frederik Schwarzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I cannot apply this patch to trunk. klines/renderer.cpp fails. The .rej file has 280 lines. Any idea why this happens?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are you using the updated diff? (Diff 4):
https://svn.reviewboard.kde.org/r/5399/diff/4/</pre>
<br />
<p>- Lindsay</p>
<br />
<p>On April 8th, 2011, 5:17 a.m., Lindsay Mathieson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Lindsay Mathieson.</div>
<p style="color: grey;"><i>Updated April 8, 2011, 5:17 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updates klines to use KGameRenderer and KGameRenderedItem in place of QSvgRenderer and QGraphicsPixmapItem
Removes KPixmapCache usage</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Playing game
Changing themes
Resizing game
Comparison with original</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/klines/animator.cpp <span style="color: grey">(1227353)</span></li>
<li>/trunk/KDE/kdegames/klines/ballitem.h <span style="color: grey">(1227353)</span></li>
<li>/trunk/KDE/kdegames/klines/ballitem.cpp <span style="color: grey">(1227353)</span></li>
<li>/trunk/KDE/kdegames/klines/klines.cpp <span style="color: grey">(1227353)</span></li>
<li>/trunk/KDE/kdegames/klines/previewitem.cpp <span style="color: grey">(1227353)</span></li>
<li>/trunk/KDE/kdegames/klines/renderer.h <span style="color: grey">(1227353)</span></li>
<li>/trunk/KDE/kdegames/klines/renderer.cpp <span style="color: grey">(1177731)</span></li>
<li>/trunk/KDE/kdegames/klines/scene.cpp <span style="color: grey">(1227353)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5399/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>