[Kde-games-devel] Review Request: Port KBlocks to KGameRenderer

[Brian Croom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5081/
-----------------------------------------------------------

(Updated 2010-09-20 21:36:56.071055)


Review request for KDE Games, Mauricio Piacentini and Stefan Majewsky.


Changes
-------

The patch now initializes KGameRenderer with the default theme value as recommended.

My question now is whether it is really in the scope of this patch to revert KBlocks to deal with resize events by modifying the scene and item sizes instead of only adjusting the view transformation?


Summary
-------

This straightforward patch makes the KBlocks rendering code use KGameRenderer instead of making its own KGameTheme and QSvgRenderer instances


Diffs (updated)
-----

  /trunk/KDE/kdegames/kblocks/KBlocksGraphics.h 1177675 
  /trunk/KDE/kdegames/kblocks/KBlocksGraphics.cpp 1177675 
  /trunk/KDE/kdegames/kblocks/KBlocksItemGroup.cpp 1177675 
  /trunk/KDE/kdegames/kblocks/KBlocksScene.cpp 1177675 
  /trunk/KDE/kdegames/kblocks/KBlocksSvgItem.h 1177675 
  /trunk/KDE/kdegames/kblocks/KBlocksSvgItem.cpp 1177675 
  /trunk/KDE/kdegames/kblocks/kblocks.kcfg 1177675 
  /trunk/KDE/kdegames/kblocks/main.cpp 1177675 
  /trunk/KDE/kdegames/kblocks/settings.kcfgc 1177675 

Diff: http://svn.reviewboard.kde.org/r/5081/diff


Testing
-------

I have tested playing games and switching themes, and encountered no problems.


Thanks,

Brian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100920/9fc365cd/attachment.htm