[Kde-games-devel] Review Request: Port KBlocks to KGameRenderer

[Brian Croom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5081/
-----------------------------------------------------------

(Updated 2010-09-10 08:03:41.731323)


Review request for KDE Games, Mauricio Piacentini and Stefan Majewsky.


Changes
-------

I modified the patch to set the default theme in the .kcfg file instead of in the scene constructor.


Summary
-------

This straightforward patch makes the KBlocks rendering code use KGameRenderer instead of making its own KGameTheme and QSvgRenderer instances


Diffs (updated)
-----

  /trunk/KDE/kdegames/kblocks/KBlocksGraphics.h 1173706 
  /trunk/KDE/kdegames/kblocks/KBlocksGraphics.cpp 1173706 
  /trunk/KDE/kdegames/kblocks/KBlocksItemGroup.cpp 1173706 
  /trunk/KDE/kdegames/kblocks/KBlocksScene.cpp 1173706 
  /trunk/KDE/kdegames/kblocks/KBlocksSvgItem.h 1173706 
  /trunk/KDE/kdegames/kblocks/KBlocksSvgItem.cpp 1173706 
  /trunk/KDE/kdegames/kblocks/kblocks.kcfg 1173706 
  /trunk/KDE/kdegames/kblocks/main.cpp 1173706 

Diff: http://svn.reviewboard.kde.org/r/5081/diff


Testing
-------

I have tested playing games and switching themes, and encountered no problems.


Thanks,

Brian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100910/43787c44/attachment.htm