[Kde-games-devel] Review Request: add setHiddenConfigGroups() method to KScoreDialog

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5256/#review7475
-----------------------------------------------------------

Ship it!


Sorry, I've been busy with "back to school" and haven't had a chance to test it or look it over thoroughly.

Firstly, I'm debating if it makes more sense to have a setVisibleGroups() or a setHiddenGroups(). I guess setHiddenGroups is simpler as setHiddenGroups(emptyList) returns you to the default behaviour, where it would be more work to "reset" with setVisibleGroups. I guess the problem is that it's an ugly, hackish API so it's probably never going to be very elegant. But considering that you'll likely be the only user of this method, I guess Stefan is right and it really doesn't matter.


svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp
<http://svn.reviewboard.kde.org/r/5256/#comment7678>

    KDE and Qt code typically defaults to QList as a sequential container. So since this feature has no explicit need for adjacent memory storage, all uses of QVector in this patch should be replaced with QList.


Other than that, I'd say it's fine to commit. Please reference this ReviewBoard URL in you commit message.

- Parker


On 2010-09-05 01:51:46, nihui wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5256/
> -----------------------------------------------------------
> 
> (Updated 2010-09-05 01:51:46)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Add a method to class KScoreDialog in order to make it be able to hide some score groups if necessary.
> The score dialog usually show all the groups.
> http://lists.kde.org/?l=kde-games-devel&m=128358396214694
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1170459 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1170459 
> 
> Diff: http://svn.reviewboard.kde.org/r/5256/diff
> 
> 
> Testing
> -------
> 
> Tested and it works fine.
> 
> 
> Screenshots
> -----------
> 
> Usage example
>   http://svn.reviewboard.kde.org/r/5256/s/496/
> 
> 
> Thanks,
> 
> nihui
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100908/14d0f830/attachment.htm