[Kde-games-devel] Review Request: add setHiddenConfigGroups() method to KScoreDialog

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5256/#review7474
-----------------------------------------------------------

Ship it!


At first, I chose not to comment on this, because I'm lacking experience with KScoreDialog hacking. Unfortunately, Parker and Matt are not available.

>From my side, nothing speaks against the patch. It doesn't matter that much to add a new method to a class from a library which I hope to deprecate soon.

- Stefan


On 2010-09-05 01:51:46, nihui wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5256/
> -----------------------------------------------------------
> 
> (Updated 2010-09-05 01:51:46)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Add a method to class KScoreDialog in order to make it be able to hide some score groups if necessary.
> The score dialog usually show all the groups.
> http://lists.kde.org/?l=kde-games-devel&m=128358396214694
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1170459 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1170459 
> 
> Diff: http://svn.reviewboard.kde.org/r/5256/diff
> 
> 
> Testing
> -------
> 
> Tested and it works fine.
> 
> 
> Screenshots
> -----------
> 
> Usage example
>   http://svn.reviewboard.kde.org/r/5256/s/496/
> 
> 
> Thanks,
> 
> nihui
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100908/15eaec41/attachment.htm