<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5256/">http://svn.reviewboard.kde.org/r/5256/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I've been busy with "back to school" and haven't had a chance to test it or look it over thoroughly.
Firstly, I'm debating if it makes more sense to have a setVisibleGroups() or a setHiddenGroups(). I guess setHiddenGroups is simpler as setHiddenGroups(emptyList) returns you to the default behaviour, where it would be more work to "reset" with setVisibleGroups. I guess the problem is that it's an ugly, hackish API so it's probably never going to be very elegant. But considering that you'll likely be the only user of this method, I guess Stefan is right and it really doesn't matter.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5256/diff/2/?file=35211#file35211line57" style="color: black; font-weight: bold; text-decoration: underline;">svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">typedef QList<KScoreDialog::FieldInfo> GroupScores; ///<The list of scores in a group</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">57</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QVector</span><span class="o"><</span><span class="n">QByteArray</span><span class="o">></span> <span class="n">hiddenGroups</span><span class="p">;</span> <span class="c1">/// Groups that should not be shown in the dialog</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KDE and Qt code typically defaults to QList as a sequential container. So since this feature has no explicit need for adjacent memory storage, all uses of QVector in this patch should be replaced with QList.</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Other than that, I'd say it's fine to commit. Please reference this ReviewBoard URL in you commit message.</pre>
<p>- Parker</p>
<br />
<p>On September 5th, 2010, 1:51 a.m., nihui wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By nihui.</div>
<p style="color: grey;"><i>Updated 2010-09-05 01:51:46</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a method to class KScoreDialog in order to make it be able to hide some score groups if necessary.
The score dialog usually show all the groups.
http://lists.kde.org/?l=kde-games-devel&m=128358396214694
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested and it works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h <span style="color: grey">(1170459)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp <span style="color: grey">(1170459)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5256/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5256/s/496/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/05/hdg_400x100.png" style="border: 1px black solid;" alt="Usage example" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>