[Kde-games-devel] Re: Review Request: fix 215352 bug

[Antonis Tsiapaliokas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5682/
-----------------------------------------------------------

(Updated 2010-10-28 16:12:58.905668)


Review request for KDE Games.


Changes
-------

oh... I did not have thought this way... You have right... So i have create another patch, which disables the undo button when someone wins the game... And the game compiles fine...


Summary
-------

Hello

This is my first effort to help the kdegames,so i am sorry if i have done something wrong...This bug regards the kmahjongg game.This patch is fixing the bug 215352.All the information that you will need, are located into the bug report... With a few words, after someone wins, the undo button is still enable and full functional...


This addresses bug 215352.
    https://bugs.kde.org/show_bug.cgi?id=215352


Diffs (updated)
-----

  trunk/KDE/kdegames/kmahjongg/kmahjongg.cpp 1190695 

Diff: http://svn.reviewboard.kde.org/r/5682/diff


Testing
-------

The kmahjongg game compiles and runs fine.But there is a problem,which it will sound to you very silly... I have create the patch but i cannot win the game so i cannot test my patch... But i have found another way to test my patch, and there works fine... If you look at the kmahjongg.cpp (it is located into the kdegames/kmahjongg) at the lines 174("undoAction = KStandardGameAction::undo(this, SLOT(undo()), actionCollection());") and 119-120 (connect( bw, SIGNAL( gameOver(unsigned short , unsigned short)), this,SLOT( gameOver(unsigned short , unsigned short)));) those two functions are connected with the bw object.So if i add the code from my patch into the KMahjongg::undo() method and after i make 10 moves into the game, i will be able to undo only the last one because when i hit the undo button then, the code from my patch is called and the undo button is becoming dissable (from enable). So instead of adding the code into the KMahjongg::undo(), if i add it, into the KMahjongg::gameOver() then it should work fine... I know that this is very wrong, as regards the testing for my patch but i could not find something better...


Thanks,

Antonis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20101028/ed6efd1a/attachment.htm