[Kde-games-devel] Re: Review Request: fix 215352 bug

[Wolfgang Rohdewald]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5682/#review8410
-----------------------------------------------------------


I as a user would ask why I am allowed to select the undo action when it is not legal.
Maybe it would be better to disable the undo action whenever it should not be possible to undo.
That way you would not have to introduce a error message.

- Wolfgang


On 2010-10-28 13:16:06, Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5682/
> -----------------------------------------------------------
> 
> (Updated 2010-10-28 13:16:06)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Hello
> 
> This is my first effort to help the kdegames,so i am sorry if i have done something wrong...This bug regards the kmahjongg game.This patch is fixing the bug 215352.All the information that you will need, are located into the bug report... With a few words, after someone wins, the undo button is still enable and full functional...
> 
> 
> This addresses bug 215352.
>     https://bugs.kde.org/show_bug.cgi?id=215352
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.cpp 1190650 
> 
> Diff: http://svn.reviewboard.kde.org/r/5682/diff
> 
> 
> Testing
> -------
> 
> The kmahjongg game compiles and runs fine.But there is a problem,which it will sound to you very silly... I have create the patch but i cannot win the game so i cannot test my patch... But i have found another way to test my patch, and there works fine... If you look at the kmahjongg.cpp (it is located into the kdegames/kmahjongg) at the lines 174("undoAction = KStandardGameAction::undo(this, SLOT(undo()), actionCollection());") and 119-120 (connect( bw, SIGNAL( gameOver(unsigned short , unsigned short)), this,SLOT( gameOver(unsigned short , unsigned short)));) those two functions are connected with the bw object.So if i add the code from my patch into the KMahjongg::undo() method and after i make 10 moves into the game, i will be able to undo only the last one because when i hit the undo button then, the code from my patch is called and the undo button is becoming dissable (from enable). So instead of adding the code into the KMahjongg::undo(), if i add it, into the KMahjongg::gameOver() then it should work fine... I know that this is very wrong, as regards the testing for my patch but i could not find something better...
> 
> 
> Thanks,
> 
> Antonis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20101028/e9186473/attachment.htm