[Kde-games-devel] moved Kajongg from playground to kdereview

[Jeremy Wickersheimer]

Hi,

I noticed the dialog used on the player turn does not darken the rest
of the app, only the one to act on other players discarded tiles.
Could it be simply the : self.clientDialog.setModal(not IAmActive)
flag that differs ?

Also i tried again and the error i got is in kahjongg.py

Traceback (most recent call last):
  File "/home/jeremy/programmation/kde/kajongg/src/humanclient.py",
line 321, in selectedAnswer
    self.selectDefault()
  File "/home/jeremy/programmation/kde/kajongg/src/humanclient.py",
line 314, in selectDefault
    self.deferred.callback(answer)
  File "/usr/lib64/python2.6/site-packages/twisted/internet/defer.py",
line 238, in callback
    self._startRunCallbacks(result)
  File "/usr/lib64/python2.6/site-packages/twisted/internet/defer.py",
line 307, in _startRunCallbacks
    self._runCallbacks()
--- <exception caught here> ---
  File "/usr/lib64/python2.6/site-packages/twisted/internet/defer.py",
line 323, in _runCallbacks
    self.result = callback(self.result, *args, **kw)
  File "/home/jeremy/programmation/kde/kajongg/src/humanclient.py",
line 499, in answered
    self.callServer('claim', self.table[0], answer)
exceptions.TypeError: 'ClientTable' object does not support indexing



WICKERSHEIMER
Jérémy





On Sat, Feb 20, 2010 at 12:22 AM, Wolfgang Rohdewald
<wolfgang at rohdewald.de> wrote:
> On Friday 19 February 2010, Jeremy Wickersheimer wrote:
>> For the kwin issue i am just guessing but it could be just an
>> option on the dialog (modal / non modal).
>
> One of the KWin authors, Martin Grässlin, just told me
> this is currently not possible, see
> https://bugs.kde.org/show_bug.cgi?id=172921
> He offered help over IRC #kwin for a specific solution
> but after having read the bug comments I think I will first
> try the alternatives.
>
>> Or if you make the board dimensions square, you would have
>> more horizontal space than vertical space, so a panel on the
>> right could be used.
>
> Actually my girl friend just had the same idea. Of course
> it means the prompts are always left or right (configurable).
>
>> But i dont think the buttons have to be very big, and for
>> example they might fit over the bottom part of the wall.
>
> There will occasionally be more buttons like "call at beginning",
> "rob the kong" - this might get crowded. Especially considering
> finding short translations in all languages.
>
> Or only show a closed combo box for all actions?
> The keyboard shortcuts would of course also work
> when the combo is closed. Then maybe I could even keep some
> free space in the center for this dialog, by shrinking the
> discarded tiles and only placing them around the dialog.
>
>> Making the positioning configurable could be an option.
>
> easy if I have to introduce a new config tab for the user
> interface anyway.
>
>> > will introduce an option "propose melds for tiles on hand",
>> > default True, because that is the better choice for
>> > beginners, I think.
>>
>> Or one may think this would lead the beginners to believe that
>> the only good matches are with the same tiles.
>> I think the sorting makes it easy enough, but i am no
>> beginner, perhaps some user testing can tell :)
>
> OK, I have no problem with default False
>
>> I'll try again next week, if get the error again i'll email it
>> to you.
>
> You should still have it in /var/log/somewhere.
>
>> I'll maybe also try some UI adjusting (easy to do in
>> python). Then i'll probably have lots of ideas to share with
>> you later, custom rules etc .. :)
>
> That would be great!
>
> --
> Wolfgang
>