[Kde-games-devel] Review Request: Port Kollision to use KGameRenderer

[Brian Croom]

> On 2010-08-18 08:21:58, Dmitry Suzdalev wrote:
> > To fix scrollbar things - maybe just increase minimumSize of the view widget?
> 
> Stefan Majewsky wrote:
>     Without having looked at the code, you probably want QGraphicsView::set{Horizontal,Vertical}ScrollBarPolicy(Qt::ScrollBarAlwaysOff).

After experimenting with things for a bit, it seems like the size is only an issue because of my low-res netbook screen. The QGraphicsView plus the window chrome is too tall to fit on the screen along with the panel. I suppose the proper solution would thus be to allow the view to be resizable and scale the scene to fit instead of maintaining the fixed window size, however my attempts to use fitInView had very strange results, and that change is outside of the scope of this patch anyway.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5059/#review7128
-----------------------------------------------------------


On 2010-08-17 15:20:31, Brian Croom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5059/
> -----------------------------------------------------------
> 
> (Updated 2010-08-17 15:20:31)
> 
> 
> Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.
> 
> 
> Summary
> -------
> 
> This patch ports Kollision to use the KGameRenderer class for rendering balls.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kollision/CMakeLists.txt 1164677 
>   /trunk/KDE/kdegames/kollision/ball.h 1164677 
>   /trunk/KDE/kdegames/kollision/ball.cpp 1164677 
>   /trunk/KDE/kdegames/kollision/main.cpp 1164677 
>   /trunk/KDE/kdegames/kollision/mainarea.h 1164677 
>   /trunk/KDE/kdegames/kollision/mainarea.cpp 1164677 
>   /trunk/KDE/kdegames/kollision/pictures/CMakeLists.txt 1164677 
>   /trunk/KDE/kdegames/kollision/renderer.h 1164677 
>   /trunk/KDE/kdegames/kollision/renderer.cpp 1164677 
> 
> Diff: http://reviewboard.kde.org/r/5059/diff
> 
> 
> Testing
> -------
> 
> Everything seems to work.
> 
> 
> Thanks,
> 
> Brian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100822/9c71e1b8/attachment.htm