<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5059/">http://reviewboard.kde.org/r/5059/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 18th, 2010, 8:21 a.m., <b>Dmitry Suzdalev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To fix scrollbar things - maybe just increase minimumSize of the view widget?</pre>
</blockquote>
<p>On August 18th, 2010, 10:07 a.m., <b>Stefan Majewsky</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Without having looked at the code, you probably want QGraphicsView::set{Horizontal,Vertical}ScrollBarPolicy(Qt::ScrollBarAlwaysOff).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After experimenting with things for a bit, it seems like the size is only an issue because of my low-res netbook screen. The QGraphicsView plus the window chrome is too tall to fit on the screen along with the panel. I suppose the proper solution would thus be to allow the view to be resizable and scale the scene to fit instead of maintaining the fixed window size, however my attempts to use fitInView had very strange results, and that change is outside of the scope of this patch anyway.</pre>
<br />
<p>- Brian</p>
<br />
<p>On August 17th, 2010, 3:20 p.m., Brian Croom wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.</div>
<div>By Brian Croom.</div>
<p style="color: grey;"><i>Updated 2010-08-17 15:20:31</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch ports Kollision to use the KGameRenderer class for rendering balls.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything seems to work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/kollision/CMakeLists.txt <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/ball.h <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/ball.cpp <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/main.cpp <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/mainarea.h <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/mainarea.cpp <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/pictures/CMakeLists.txt <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/renderer.h <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/renderer.cpp <span style="color: grey">(1164677)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5059/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>