[Kde-games-devel] Review Request: Port Kollision to use KGameRenderer

[Parker Coates]

> On 2010-08-17 14:54:24, Parker Coates wrote:
> > /trunk/KDE/kdegames/kollision/mainarea.cpp, lines 174-177
> > <http://reviewboard.kde.org/r/5059/diff/1/?file=34108#file34108line174>
> >
> >     This is now a very interesting method. :)

You could drop the parentheses, though.


- Parker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5059/#review7107
-----------------------------------------------------------


On 2010-08-17 13:49:43, Brian Croom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5059/
> -----------------------------------------------------------
> 
> (Updated 2010-08-17 13:49:43)
> 
> 
> Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.
> 
> 
> Summary
> -------
> 
> This patch ports Kollision to use the KGameRenderer class for rendering balls.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kollision/CMakeLists.txt 1164677 
>   /trunk/KDE/kdegames/kollision/ball.h 1164677 
>   /trunk/KDE/kdegames/kollision/ball.cpp 1164677 
>   /trunk/KDE/kdegames/kollision/main.cpp 1164677 
>   /trunk/KDE/kdegames/kollision/mainarea.h 1164677 
>   /trunk/KDE/kdegames/kollision/mainarea.cpp 1164677 
>   /trunk/KDE/kdegames/kollision/pictures/CMakeLists.txt 1164677 
>   /trunk/KDE/kdegames/kollision/renderer.h 1164677 
>   /trunk/KDE/kdegames/kollision/renderer.cpp 1164677 
> 
> Diff: http://reviewboard.kde.org/r/5059/diff
> 
> 
> Testing
> -------
> 
> Everything seems to work.
> 
> 
> Thanks,
> 
> Brian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100817/116b117d/attachment.htm