[Kde-games-devel] Review Request: Port Kollision to use KGameRenderer

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5059/#review7107
-----------------------------------------------------------

Ship it!


Looks good to me.


/trunk/KDE/kdegames/kollision/ball.cpp
<http://reviewboard.kde.org/r/5059/#comment7253>

    Unused header.



/trunk/KDE/kdegames/kollision/mainarea.cpp
<http://reviewboard.kde.org/r/5059/#comment7252>

    OT: Is there any reason this painting couldn't be done directly to a QPixmap to avoid the expensive image->pixmap conversion?



/trunk/KDE/kdegames/kollision/mainarea.cpp
<http://reviewboard.kde.org/r/5059/#comment7254>

    This is now a very interesting method. :)


- Parker


On 2010-08-17 13:49:43, Brian Croom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5059/
> -----------------------------------------------------------
> 
> (Updated 2010-08-17 13:49:43)
> 
> 
> Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.
> 
> 
> Summary
> -------
> 
> This patch ports Kollision to use the KGameRenderer class for rendering balls.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kollision/CMakeLists.txt 1164677 
>   /trunk/KDE/kdegames/kollision/ball.h 1164677 
>   /trunk/KDE/kdegames/kollision/ball.cpp 1164677 
>   /trunk/KDE/kdegames/kollision/main.cpp 1164677 
>   /trunk/KDE/kdegames/kollision/mainarea.h 1164677 
>   /trunk/KDE/kdegames/kollision/mainarea.cpp 1164677 
>   /trunk/KDE/kdegames/kollision/pictures/CMakeLists.txt 1164677 
>   /trunk/KDE/kdegames/kollision/renderer.h 1164677 
>   /trunk/KDE/kdegames/kollision/renderer.cpp 1164677 
> 
> Diff: http://reviewboard.kde.org/r/5059/diff
> 
> 
> Testing
> -------
> 
> Everything seems to work.
> 
> 
> Thanks,
> 
> Brian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100817/5984fb67/attachment-0001.htm