[Kde-games-devel] Review Request: Port KReversi to use KGameRenderer

[Dmitry Suzdalev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4948/#review6928
-----------------------------------------------------------



/trunk/KDE/kdegames/kreversi/kreversichip.cpp
<http://reviewboard.kde.org/r/4948/#comment6909>

    Let's have it static here, no need for it to be exportable I guess :)
    
    This is just my rule of thumb - every local variable in each compilation unit should be made static (and preferably const) if not needed otherwise.
    
    I mean 
    static QPixmap* ...



/trunk/KDE/kdegames/kreversi/kreversichip.cpp
<http://reviewboard.kde.org/r/4948/#comment6911>

    This could also be cached as a member of KReversiChip and then you could just call setVisible(show) on it, but I guess this is a micro optimization, as this won't be called so often.
    
    Ah, and if caching you'll still need to recreate it when size changes...
    
    Well, see for yourself :)


- Dmitry


On 2010-08-09 20:21:40, Brian Croom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4948/
> -----------------------------------------------------------
> 
> (Updated 2010-08-09 20:21:40)
> 
> 
> Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.
> 
> 
> Summary
> -------
> 
> This patch modifies KReversi to use KGameRenderer for loading its theme and generating/receiving its pixmaps. This is my first port attempt (first KDE contribution woohoo!) so please critique.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kreversi/CMakeLists.txt 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversichip.h 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversichip.cpp 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversirenderer.h 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversirenderer.cpp 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversiscene.h 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversiscene.cpp 1161066 
>   /trunk/KDE/kdegames/kreversi/mainwindow.cpp 1161066 
>   /trunk/KDE/kdegames/kreversi/pics/CMakeLists.txt 1161066 
>   /trunk/KDE/kdegames/kreversi/pics/default_theme.desktop PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4948/diff
> 
> 
> Testing
> -------
> 
> I have tested the various hinting/marking options, changing chip color set, etc. Everything seems to be working.
> 
> 
> Thanks,
> 
> Brian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100810/5c98ea30/attachment-0001.htm