<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4948/">http://reviewboard.kde.org/r/4948/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/4948/diff/3/?file=33457#file33457line32" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdegames/kreversi/kreversichip.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KReversiChip::KReversiChip( ChipColor color, const KReversiChipFrameSet* frameSet, QGraphicsScene* scene )</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QPixmap* KReversiChip::s_lastMoveMarker;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">KReversiChip</span><span class="o">::</span><span class="n">KReversiChip</span><span class="p">(</span> <span class="n">ChipColor</span> <span class="n">color</span><span class="p">,</span> <span class="k">const</span> <span class="n">KReversiChipFrameSet</span><span class="o">*</span> <span class="n">frameSet</span><span class="p">,</span> <span class="n">QGraphicsScene</span><span class="o">*</span> <span class="n">scene</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QPixmap</span><span class="o">*</span> <span class="n">KReversiChip</span><span class="o">::</span><span class="n">s_lastMoveMarker</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let's have it static here, no need for it to be exportable I guess :)
This is just my rule of thumb - every local variable in each compilation unit should be made static (and preferably const) if not needed otherwise.
I mean
static QPixmap* ...</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/4948/diff/3/?file=33457#file33457line77" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdegames/kreversi/kreversichip.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KReversiChip::KReversiChip( ChipColor color, const KReversiChipFrameSet* frameSet, QGraphicsScene* scene )</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QPixmap* KReversiChip::s_lastMoveMarker;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">61</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QPixmap</span> <span class="n">origPix</span> <span class="o">=</span> <span class="n">pixmap</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">76</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QGraphicsItem</span><span class="o">*</span> <span class="n">marker</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QGraphicsPixmapItem</span><span class="p">(</span><span class="o">*</span><span class="n">s_lastMoveMarker</span><span class="p">,</span> <span class="k">this</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This could also be cached as a member of KReversiChip and then you could just call setVisible(show) on it, but I guess this is a micro optimization, as this won't be called so often.
Ah, and if caching you'll still need to recreate it when size changes...
Well, see for yourself :)</pre>
</div>
<br />
<p>- Dmitry</p>
<br />
<p>On August 9th, 2010, 8:21 p.m., Brian Croom wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.</div>
<div>By Brian Croom.</div>
<p style="color: grey;"><i>Updated 2010-08-09 20:21:40</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch modifies KReversi to use KGameRenderer for loading its theme and generating/receiving its pixmaps. This is my first port attempt (first KDE contribution woohoo!) so please critique.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested the various hinting/marking options, changing chip color set, etc. Everything seems to be working.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/kreversi/CMakeLists.txt <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/kreversichip.h <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/kreversichip.cpp <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/kreversirenderer.h <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/kreversirenderer.cpp <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/kreversiscene.h <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/kreversiscene.cpp <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/mainwindow.cpp <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/pics/CMakeLists.txt <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/pics/default_theme.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4948/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>