[Kde-games-devel] Review Request: Port KReversi to use KGameRenderer
Brian Croom
brian.s.croom at gmail.com
Tue Aug 10 02:21:59 CEST 2010
> On 2010-08-09 21:28:03, Stefan Majewsky wrote:
> > /trunk/KDE/kdegames/kreversi/kreversichip.cpp, line 3
> > <http://reviewboard.kde.org/r/4948/diff/3/?file=33457#file33457line3>
> >
> > Brian, you should add your copyright for legal reasons, and if you like, you can also add a credit in main.cpp to show up in the about dialog. I think this big contribution justifies this.
i.e. add a copyright line in each source file that my patch touches?
> On 2010-08-09 21:28:03, Stefan Majewsky wrote:
> > /trunk/KDE/kdegames/kreversi/pics/default_theme.desktop, lines 1-27
> > <http://reviewboard.kde.org/r/4948/diff/3/?file=33464#file33464line1>
> >
> > Huh? From where did you get the translations? I can't find them in my working dir.
I grabbed the default_theme.desktop file from KSame and did a find/replace. Is that ok?
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4948/#review6926
-----------------------------------------------------------
On 2010-08-09 20:21:40, Brian Croom wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4948/
> -----------------------------------------------------------
>
> (Updated 2010-08-09 20:21:40)
>
>
> Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.
>
>
> Summary
> -------
>
> This patch modifies KReversi to use KGameRenderer for loading its theme and generating/receiving its pixmaps. This is my first port attempt (first KDE contribution woohoo!) so please critique.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdegames/kreversi/CMakeLists.txt 1161066
> /trunk/KDE/kdegames/kreversi/kreversichip.h 1161066
> /trunk/KDE/kdegames/kreversi/kreversichip.cpp 1161066
> /trunk/KDE/kdegames/kreversi/kreversirenderer.h 1161066
> /trunk/KDE/kdegames/kreversi/kreversirenderer.cpp 1161066
> /trunk/KDE/kdegames/kreversi/kreversiscene.h 1161066
> /trunk/KDE/kdegames/kreversi/kreversiscene.cpp 1161066
> /trunk/KDE/kdegames/kreversi/mainwindow.cpp 1161066
> /trunk/KDE/kdegames/kreversi/pics/CMakeLists.txt 1161066
> /trunk/KDE/kdegames/kreversi/pics/default_theme.desktop PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/4948/diff
>
>
> Testing
> -------
>
> I have tested the various hinting/marking options, changing chip color set, etc. Everything seems to be working.
>
>
> Thanks,
>
> Brian
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100810/bd1ae495/attachment.html
More information about the kde-games-devel
mailing list