[Kde-games-devel] Review Request: Makes the status text in KGoldrunner easier to translate properly

[Ian Wadham]

On Sun, 24 May 2009 3:06:31 am Frederik Schwarzer wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/754/
> -----------------------------------------------------------
>
I have not used Reviewboard before.  So how do I reply to
this?  I went to the above link, read the patches and your
comments, registered, logged it, saw My Dashboard and
all that jazz ... but where is the reply button?  And where
is that "ship it" thing?  Not that I agree to ship it yet, just so
I can save time when I do.  Any way, I will reply here.

Thank you very much for working on this, Frederik.  In
general I like very much what you have done, but ...

- Please work off the latest revision I made (and
  announced in my last email about this topic):
  revision 971746, Sat May 23 11:58:59 2009 UTC

- In that rev I changed myPause back to KAction * and
  uncommented some initialization in ::setupActions ...
  in particular a "setAlternate (Qt::Key_Escape)".  That code
  will probably not work with a QAction *.

- ".toString()" should be ".toString(QKeySequence::NativeText)"
   as originally requested by Albert last year.

Maybe you can test the latter in German translation and
with a German keyboard.  IIRC (and I might have forgotten),
key-names with Shift, Ctrl and other modifiers will be shown
correctly in the Pause/Resume messages if you use
QKeySequence::NativeText, but not if you use the () default.

All the best, Frederik, and thanks again for your help,
Cheers, Ian W.