[Kde-games-devel] Review Request: Makes the status text in KGoldrunner easier to translate properly

[Frederik Schwarzer]

On Sunday 24. May 2009 00:58:26 Ian Wadham wrote:
> On Sun, 24 May 2009 3:06:31 am Frederik Schwarzer wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/754/
> > -----------------------------------------------------------
> >
> I have not used Reviewboard before.  So how do I reply to
> this?  I went to the above link, read the patches and your
> comments, registered, logged it, saw My Dashboard and
> all that jazz ... but where is the reply button?  And where
> is that "ship it" thing?  Not that I agree to ship it yet, just so
> I can save time when I do.  Any way, I will reply here.

Click the Review button on the upper right. There is a checkbox then.


> - Please work off the latest revision I made (and
>   announced in my last email about this topic):
>   revision 971746, Sat May 23 11:58:59 2009 UTC

Done.


> - In that rev I changed myPause back to KAction * and
>   uncommented some initialization in ::setupActions ...
>   in particular a "setAlternate (Qt::Key_Escape)".  That code
>   will probably not work with a QAction *.

Done.


> - ".toString()" should be ".toString(QKeySequence::NativeText)"
>    as originally requested by Albert last year.

Done.


> Maybe you can test the latter in German translation and
> with a German keyboard.

Tested with Space (is Leertaste in German then) and Ctrl+R (shown as Strg+R),
so it looks fine.


Regards