[Kde-games-devel] Review Request: KAtomic first run resize bug

[Alan Alpert]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/653/
-----------------------------------------------------------

(Updated 2009-05-19 21:19:30.547256)


Review request for KDE Games.


Changes
-------

Change scope, in that the changes to these games should be minimal and I'm working on a proper long term solution to the issue for 4.4.


Summary (updated)
-------

Having looked into the proper solution to the Multiple Resize Problems I don't think it'll get done for 4.3. I thus recommend removing the code in KAtomic and KLines that leads to bad behaviour on first run, even though it's not optimal (speed-wise). KAtomic and KLines don't seem to be too badly affected by the slowness, and I think it's better that it does the right thing slowly than the wrong thing some of the time.

The proper solution that I envisage (which doesn't really have anything to do with this specifc patch) is to get rid of the bits in KMainWindow that are just working around Qt. Fixing those, and maybe one or two other Qt bugs along the way, should result in both a single resize and better code. But it could take a while. 


Diffs (updated)
-----

  trunk/KDE/kdegames/katomic/gamewidget.cpp 967534 
  trunk/KDE/kdegames/klines/mwidget.cpp 967534 

Diff: http://reviewboard.kde.org/r/653/diff


Testing (updated)
-------

Both KAtomic and KLines were compiled and ran fine both with and without their configuration files existing.


Screenshots
-----------

The undesired behaviour
  http://reviewboard.kde.org/r/653/s/110/


Thanks,

Alan