[Kde-games-devel] Review Request: KAtomic first run resize bug

[Dmitry Suzdalev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/653/#review1163
-----------------------------------------------------------

Ship it!


I agree.
Let's remove it and have a common proper fix.
Thanks for looking into this!

- Dmitry


On 2009-05-19 21:19:30, Alan Alpert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/653/
> -----------------------------------------------------------
> 
> (Updated 2009-05-19 21:19:30)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Having looked into the proper solution to the Multiple Resize Problems I don't think it'll get done for 4.3. I thus recommend removing the code in KAtomic and KLines that leads to bad behaviour on first run, even though it's not optimal (speed-wise). KAtomic and KLines don't seem to be too badly affected by the slowness, and I think it's better that it does the right thing slowly than the wrong thing some of the time.
> 
> The proper solution that I envisage (which doesn't really have anything to do with this specifc patch) is to get rid of the bits in KMainWindow that are just working around Qt. Fixing those, and maybe one or two other Qt bugs along the way, should result in both a single resize and better code. But it could take a while. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/katomic/gamewidget.cpp 967534 
>   trunk/KDE/kdegames/klines/mwidget.cpp 967534 
> 
> Diff: http://reviewboard.kde.org/r/653/diff
> 
> 
> Testing
> -------
> 
> Both KAtomic and KLines were compiled and ran fine both with and without their configuration files existing.
> 
> 
> Screenshots
> -----------
> 
> The undesired behaviour
>   http://reviewboard.kde.org/r/653/s/110/
> 
> 
> Thanks,
> 
> Alan
> 
>