[Kde-games-devel] Review Request: KAtomic first run resize bug

[Alan Alpert]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/653/
-----------------------------------------------------------

(Updated 2009-05-03 20:35:17.493602)


Review request for KDE Games.


Changes
-------

This fix hopes to maintain the optimization that is no longer working.


Summary (updated)
-------

This fix only does one resize after startup, or at least in the first N ms. I'm not sure about the value of N but 10ms worked for me, probably due to the event ending up later in the event loop than the resizes (or 10ms being longer than it takes to load katomic without a resize on my pc, also possible).

While this approach does prevent the original problem in the screenshot and also only performs an expensive resize once it does have the drawback that an empty window (or the unsized one in the screenshot, but I think empty is better) is shown for at least one frame in the period between the application having started and the resize finishing. There are three ways I can think of to deal with this more minor bug.

1) Show a 'Loading, please wait' screen for that split-second, like plasma applets.
2) Store a precalculated image, probably saved on last application exit, and show that before hand, which will be slightly off but fast and the difference probably won't be as noticable as a large white expanse.
3) Don't worry about it - it's only a split-second while starting up. If it really does only do the resize once then even on slow computers it should finish loading before the users thinks something is wrong.

If there is a convenient way to do option 1 with KDE's libraries (like there is in plasma) then option 1 might be worth the effort but otherwise I'm leaning towards option 3.


Diffs (updated)
-----

  trunk/KDE/kdegames/katomic/gamewidget.h 962713 
  trunk/KDE/kdegames/katomic/gamewidget.cpp 962713 

Diff: http://reviewboard.kde.org/r/653/diff


Testing (updated)
-------

KAtomic @r962713 with the patch compiled and ran without error, with and without katomicrc, save the issue explained above. Debug statements indicated that in all tests I did the one or two resizes at startup were ignored and then one was done later, as intended.


Screenshots
-----------

The undesired behaviour
  http://reviewboard.kde.org/r/653/s/110/


Thanks,

Alan