[Kde-games-devel] Review Request: Correcting inactive behaviour

[Dirk Leifeld]

> On 2009-03-26 17:17:04, Mauricio Piacentini wrote:
> > Using the menus or any other window should pause the game, by design. This includes the difficulty change, selecting the configure menu, or clicking on other windows of the desktop. So I do not think this patch applies: the fact that we pause on FocusOut is a feature, imo. Comments?

Actually the game is still paused, since the stepTimer are stopped after the focus is regaind it is started.
The variable gameState is not used in kblocks to see if the game is active. 

Only kGameDifficulty uses gameState to see if the game is active.
If gameState is Game_Active it asks before changing the difficulty and restarting the game.
If gameState is something eles it just changes the difficulty and restarts the game without asking.
And since changing the difficulty relinques a menue, it never asks.

I think restarting a game without asking is a behaviour which should be avoided.


- Dirk


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/434/#review638
-----------------------------------------------------------


On 2009-03-26 16:14:34, Dirk Leifeld wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/434/
> -----------------------------------------------------------
> 
> (Updated 2009-03-26 16:14:34)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Using the menue to switch the difficulty should not make the game inactive. But it leads to a FocusOutEvent...
> 
> 
> This addresses bug 169481.
>     https://bugs.kde.org/show_bug.cgi?id=169481
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kblocks/kblocksscene.cpp 944983 
> 
> Diff: http://reviewboard.kde.org/r/434/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dirk
> 
>