[Kde-games-devel] Review Request: Correcting inactive behaviour

[Mauricio Piacentini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/434/#review640
-----------------------------------------------------------


Your patch indeed fixes the problem with KGameDifficulty, but it disables pausing the game when a menu or the configuration dialog is opened. In this case, after patching, the game continues to run. Can you reproduce this with the patched game? So I believe you are on track for fixing the KGameDifficulty issue, but we need to have a closer look at how to do this and still keep the game pausing when a menu is invoked. Notice that we need to store the state info, as we need to know if the game was paused by the user (in which case it will not be resumed)... hum.... 

- Mauricio


On 2009-03-26 16:14:34, Dirk Leifeld wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/434/
> -----------------------------------------------------------
> 
> (Updated 2009-03-26 16:14:34)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Using the menue to switch the difficulty should not make the game inactive. But it leads to a FocusOutEvent...
> 
> 
> This addresses bug 169481.
>     https://bugs.kde.org/show_bug.cgi?id=169481
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kblocks/kblocksscene.cpp 944983 
> 
> Diff: http://reviewboard.kde.org/r/434/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dirk
> 
>