[Kde-games-devel] KPat/Freecell broken?

[Parker Coates]

On Fri, Dec 11, 2009 at 16:14, Andreas Pakulat wrote:
> Hi,
>
> I'm wondering if anybody else has problems with KPat not accepting
> mouse-clicks/drags anymore after a couple of initial moves when playing
> Freecell? The first oddness is that a double-click to move a card to the
> free-stack doesn't result in an undoable action. And then after a couple
> of movements of cards around I can suddenly not click anything anymore,
> no card reacts. Seems this happens as soon as more than one card is
> moved at once.

Yes, others have seen it. It's been reported as bug 218019. [1]

> The same happens in Spider when the first complete line from ace to king
> vanishes.

Crap. I was hoping it was Freecell specific. The reporter claimed that
he didn't have any issues in Spider, but maybe he didn't play for long
enough to clear a run.

> Saving and reloading the games helps "fixing" the problem with Spider,
> i.e. it doesn't block access to the cards until I start a new game. In
> Freecell loading a game that previously blocked also makes it playable,
> but only until the next move that involves more than one card.

Thanks for the details. Please add them to the report, if you don't
mind. If you start then stop the demo, does that have any affect?

This bug is definitely my fault, and I'm feeling pretty bad about it.
Just before the freeze I cleaned up the mouse handling and it seemed
to be working well, but I didn't really consider the custom weirdness
that Freecell adds. The major problem here is that I'm out of town for
work, away from my dev machine and I will probably won't be back until
January 5th.

I read through the code at lxr.kde.org, but I couldn't really see any
obvious problems. I probably need to run it to figure out what's going
on, but if I had to guess, I'd say the fix won't be that complicated.
If someone else wants to take a stab at fixing this, I'd be more than
happy to try to support them, but I realise that this is asking a lot.
If anyone has a git-svn checkout and is willing to run a git-bisect to
figure out which commit broke this, that would certainly help narrow
down the issue, too.

Sorry,

Parker


[1] https://bugs.kde.org/show_bug.cgi?id=218019