[Kde-games-devel] Bomber into kde 4.2?

[John-Paul Stanford]

Hi,

Thanks for the feedback, I'll look into these.

Cheers,
JP.

-----Original Message-----
From: Albert Astals Cid [mailto:aacid at kde.org] 
Sent: 14 September 2008 05:24 PM
To: KDE games development
Subject: Re: [Kde-games-devel] Bomber into kde 4.2?

A Diumenge 14 Setembre 2008, John-Paul Stanford va escriure:
> Hi,
>
> Thanks to Eugene reworking the artwork( Looks awesome BTW... ), I think
> bomber is pretty
> much done as far as I know. I made the new theme the default one and
remove
> the old one I
> created.
>
> I would like to see bomber go into KDE 4.2, so was wondering if the kde
> games team wanted this
> to happen? and if so, what needs to be done?

Can you try to fix all krazy issues
http://www.englishbreakfastnetwork.org/krazy/reports/playground/games/bomber
/index.html
Shout if you need help solving any issue

I get lots of QPainter warnings on startup
	QPainter::restore: Unbalanced save/restore
is particullary ugly

There's no icon?

"A KDE4 Application" sucks a bit as description :D

I'd convert 
  i18n("Level: %1", QString::fromLatin1("XX")
and his friends to
i18nc(explanation this is the default shown at start, "Level: XX");

Bomber::gameOverNow seems never to be called

Bomber::gameStateChanged seems to be called but statusBar()->showMessage did

not seem to work on game end.

i18n("Game over. Press <Space> for a new game") is wrong, the user can 
configure shortcuts so you should really use the action funciton to get the 
shortcut rather than hardcoding it here

Albert

>
> Bomber is a bit of fun really, not meant to be taken too serious.
Hopefully
> other people will
> like it as a little diversion. I used to play a simlar game when I was
> younger :-)
>
> If anyone finds any problems with it, let me know and I'll get them fixed
> ASAP.
>
> Cheers,
> JP.
>
>
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel


_______________________________________________
kde-games-devel mailing list
kde-games-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel