[Kde-games-devel] [PATCH] extract statics from KCardDialog

[Luciano Montanaro]

Il Saturday 12 January 2008 12:17:44 Andreas Pakulat ha scritto:
> Hi,
>
> the attached patch moves the static methods from KCardDialog into a
> separate namespace, which IMHO makes more sense as retrieving
> information about card decks is not bound to the dialog.

You forgot the patch! ;)

Anyway, I agree in general with your line of thought.

I have not looked at the card dialog too far, but is it possible to embed it 
as a page in a configuration dialog? I think making it possible to have 
card/background selection work as in KMahjongg would be welcome.

>
> Also it replaces the static bool with a K_GLOBAL_STATIC so the
> constructor of the static deck data is called properly on first use and
> destroyed during shutdown of the app.
>
> Another thing that it does is separating png and svg deck informations
> into separate maps so a couple of loops are avoided.
>
> Adapting of the card games in kdegames will be done by me before
> comitting this to trunk/ and comitting will probably also after we've
> done a final decision and commit about the caching as that influences
> the code in here.
>
> Comments?
>
> Andreas