[Kde-games-devel] KGameTheme Question

[David Capel]

On Mon, Aug 18, 2008 at 2:49 PM, Mauricio Piacentini <piacentini at kde.org>wrote:

> cc'ing the lists for help:
>
>
> David Capel wrote:
>
>> Hi, I'm the GSoC student that is recreating Parley's practice (and using
>> KGameTheme for its themes), if you don't remember.
>>
>> As I was finishing up, I decided it would be a good time to test the
>> creation and handling of multiple themes. Everything went fine except that
>> I
>> can't get KGameThemeSelector to find my .desktop files.
>>
>> Here is my code for the invocation of it:
>>
>> void ParleyPracticeMainWindow::slotCreatePreferencesDialog()
>> {
>>    KConfigDialog *dialog = new KConfigDialog(this, "settings",
>> Prefs::self());
>>    dialog->addPage(new KGameThemeSelector(dialog, Prefs::self()),
>> i18n("Theme"), "game_theme");
>>    dialog->show();
>> }
>>
>> You can find the rest of the code in SVN if you need it. Am I doing
>> something horribly wrong? My code is almost identical to KBlocks's...
>>
>> The default for the KConfig setting is the default theme and it has worked
>> all along (using KGameTheme), so the problem is not loading the themes
>> once
>> they are selected.
>>
>> When I traced through the code, I was it detecting my .desktop files, but
>> it
>> doesn't display them or keep them internally.
>>
>
> Hi, David. I had a look at the code and it looks fine, other than missing
> the correct icon for the theme. But I think the problem can be solved when
> we do the right thing and make the kdegameslib module for people that want
> to use code in libkdegames: I see that now you are copying some files from
> libkdegames to parley/kgametheme, and this is probably not a good strategy.
> Translators will have to translate the strings twice, for example, and
> bugfixes on one version will not make it into the other.
> The first thing I would try is to use the shared version, by modifying the
> CMakeLists.txt and see if this fixes the problem. Does it?
>
> Regards,
> Mauricio Piacentini
>

I agree that it's a bad strategy to copy code, but do we really want to make
kdegames a dependency of kdeedu? It seems best to avoid inter-module
dependencies. Do you know what the status on the port to kdelibs is? That
would be the best option, in my opinion.

Just to make sure, I diff'ed the relevent files, and the only thing that
changed was the constness of an parameter, so copying is not (currently) the
issue.

Greetings,
David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20080818/4c6b1dff/attachment-0001.htm