<div dir="ltr"><br><div class="gmail_quote">On Mon, Aug 18, 2008 at 2:49 PM, Mauricio Piacentini <span dir="ltr"><<a href="mailto:piacentini@kde.org">piacentini@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
cc'ing the lists for help:<div><div></div><div class="Wj3C7c"><br>
<br>
David Capel wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi, I'm the GSoC student that is recreating Parley's practice (and using<br>
KGameTheme for its themes), if you don't remember.<br>
<br>
As I was finishing up, I decided it would be a good time to test the<br>
creation and handling of multiple themes. Everything went fine except that I<br>
can't get KGameThemeSelector to find my .desktop files.<br>
<br>
Here is my code for the invocation of it:<br>
<br>
void ParleyPracticeMainWindow::slotCreatePreferencesDialog()<br>
{<br>
KConfigDialog *dialog = new KConfigDialog(this, "settings",<br>
Prefs::self());<br>
dialog->addPage(new KGameThemeSelector(dialog, Prefs::self()),<br>
i18n("Theme"), "game_theme");<br>
dialog->show();<br>
}<br>
<br>
You can find the rest of the code in SVN if you need it. Am I doing<br>
something horribly wrong? My code is almost identical to KBlocks's...<br>
<br>
The default for the KConfig setting is the default theme and it has worked<br>
all along (using KGameTheme), so the problem is not loading the themes once<br>
they are selected.<br>
<br>
When I traced through the code, I was it detecting my .desktop files, but it<br>
doesn't display them or keep them internally.<br>
</blockquote>
<br></div></div>
Hi, David. I had a look at the code and it looks fine, other than missing the correct icon for the theme. But I think the problem can be solved when we do the right thing and make the kdegameslib module for people that want to use code in libkdegames: I see that now you are copying some files from libkdegames to parley/kgametheme, and this is probably not a good strategy. Translators will have to translate the strings twice, for example, and bugfixes on one version will not make it into the other.<br>
The first thing I would try is to use the shared version, by modifying the CMakeLists.txt and see if this fixes the problem. Does it?<br>
<br>
Regards,<br><font color="#888888">
Mauricio Piacentini<br>
</font></blockquote></div><br>I agree that it's a bad strategy to copy code, but do we really want to make kdegames
a dependency of kdeedu? It seems best to avoid inter-module
dependencies. Do you know what the status on the port to kdelibs is? That would be the best option, in my opinion.<br><br>Just to make sure, I diff'ed the relevent files, and the only thing that changed was the constness of an parameter, so copying is not (currently) the issue.<br>
<br>Greetings,<br>David<br></div>