[Kde-games-devel] Faster KGameThemeSelector startup

Henrique Pinto tawhaki at gmail.com
Fri Jun 1 14:58:13 CEST 2007


Perhaps we can use ThreadWeaver to check the SVG files in background.
Another simple check is to add the CRC of the SVG file to the theme
'.desktop' file and check that instead of SVG validity; I believe that
would catch most file corruptions.

On 6/1/07, Mauricio Piacentini <mauricio at tabuleiro.com> wrote:
> Matt Williams wrote:
> > I agree that the full check on the SVG isn't necessary, there _shouldn't_
> > ever be any problem with loading the file anyway as long as it exists. The
> > patch looks perfect. Maybe a note should be added to the API docs saying
> > that though the theme could be loaded, no check on the SVG file contents
> > was made so the user should check it themselves? Commit away as far as I'm
> > concerned. Maraucio, what do you think?
>
> I think it is ok, although it will not immediately catch problems with
> corrupted SVG files. But the application can then use KGameTheme->load
> for this.
>
> Regards,
> Mauricio
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel
>


-- 
    Henrique Pinto
    tawhaki at gmail.com


More information about the kde-games-devel mailing list